Andy read the hook itself four times, which was three more times than it needed.
It was ninety lines. It was, and he did not have a better word for it, tidy.
It checked its arguments. It failed closed. It had a comment explaining why one
of the buffers was sized the way it was.
And it was written wrong.
mu_ctx_t *ctx = mu_ctx_acquire(req);
if (!ctx) return MU_ERR_NOCTX;
mu_ctx_t had been removed in the platform migration two years ago. So had
returning MU_ERR_* instead of raising. Andy checked the harness patches from
the closed diversion windows, the ones signed with the same key: every single one
of them used the current convention.
Whoever wrote the hook had written it in the pre-migration convention. Whoever
had been signing patches with that key since February had not.
He said so, out loud, to an empty floor at three in the morning, and then typed
it into the thumbnail job.
> the door is older than the thing using it
yes
— nix
> so we delete it?
no
— nix
> why not
because it doesn't know we found it, and it's the only way into that host
that doesn't go through something it watches
leave it exactly where it is
— nix
Andy left it exactly where it was, which felt less like a decision and more like
agreeing to keep a loaded thing in the house.